Browse Source

Fix #312. Quote file names of attachments.

Justin 10 years ago
parent
commit
ad7beb78d0
1 changed files with 3 additions and 1 deletions
  1. 3 1
      routers/repo/issue.go

+ 3 - 1
routers/repo/issue.go

@@ -1079,5 +1079,7 @@ func IssueGetAttachment(ctx *middleware.Context, params martini.Params) {
 		return
 	}
 
-	ctx.ServeFile(attachment.Path, attachment.Name)
+	// Fix #312. Attachments with , in their name are not handled correctly by Google Chrome.
+	// We must put the name in " manually.
+	ctx.ServeFile(attachment.Path, "\"" + attachment.Name + "\"")
 }